Fix: something meaningful#10
Open
fl124804gmailcom wants to merge 1 commit intoaerodrome-finance:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I optimized the test suite by reducing unnecessary repeated asynchronous calls and simplifying several expressions. In places where the same data was fetched multiple times, such as tokens or pools, the value is now retrieved once and reused. This makes the tests more efficient and easier to reason about, while keeping their behavior unchanged.
I replaced lambda expressions inside map with generator expressions in sum calls, which improves readability and follows common Python best practices. I also slightly reorganized variable names so they better reflect their purpose, for example using token, pools, epochs instead of short or less clear names.
Additionally, I added concise inline comments to explain the intent of each test and the meaning of non-obvious operations. The comments focus on why something is being tested rather than restating what the code already clearly shows. Overall, the structure and logic of the tests remain the same, but the code is now cleaner, more readable, and more efficient.