Fail build when unittests fail for PRs#60
Open
BertScholten wants to merge 2 commits intoaerius:mainfrom
Open
Conversation
Be more strict on failing tests for PRs, to avoid missing a failing test before merging.
BertScholten
force-pushed
the
fail_pr_build_when_tests_fail
branch
from
49ad3b6 to
068ce32
Compare
Not sure what the idea was behind not publishing the service and its dependencies, but it's causing the code not to be compiled/tested when building the PR. And these should be published to nexus anyway I think?
Member
Author
|
Apparantly the service modules were never tested with PR builds. Not sure if this is the correct change (I think putting the service jars in Nexus makes sense, but there might be other reasons why this shouldn't be done?), or if we should change the action to not use |
Member
|
The reasoning was that only the client parts are used by other projects. The service parts are never used by others. As a little bonus this also allows us to do the Docker part before the Maven Publish part, so that if the Docker images fail to build, it won't have pushed the client libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be more strict on failing tests for PRs, to avoid missing a failing test before merging.