Applying spotless and fixing some warnings#19
Merged
BertScholten merged 2 commits intoaerius:mainfrom Jan 31, 2025
Merged
Conversation
pom changes and annotations-on-same-line are all spotless. Other changes are based on warnings in IDE (deprecations and sonar warnings)
Not a 100% sure the region thing will work with how we deploy fileserver, but supposedly it prevents the client figuring itself out. And can always revert that change.
Hilbrand
approved these changes
Jan 31, 2025
Member
Hilbrand
left a comment
Hilbrand
left a comment
There was a problem hiding this comment.
LGTM. Not sure about the region change either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.xml changes and annotations-on-same-line are all spotless.
Other changes are based on warnings in IDE (deprecations and sonar warnings)