Merged
Conversation
Also switched to java 21. Not sure if this holds for the client library, might have to switch target to 17 there if we want to use it in 'older' projects, but lets go for 21 first.
Hilbrand
reviewed
Jan 30, 2025
.github/workflows/on-pull_request-opened-synchronize-reopened.yml
Outdated
Show resolved
Hide resolved
a6bc311 to
3f8898f
Compare
This is already defined in root pom with the exact same value, so not much point in declaring it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also switched to java 21. Not sure if this holds for the client library, might have to switch target to 17 there if we want to use it in 'older' projects, but lets go for 21 first.