Merged
Conversation
Call convertRemovedVehicleCodes in ImaerImporter after reading sources and before validation, enabling the euroclass removed codes feature. Includes short-circuit optimization when no removed codes are configured, and integration test to verify the wiring.
JornC
force-pushed
the
aer-4143-euroclass-warning
branch
from
09e96cd to
bfa3dfe
Compare
source/imaer-gml/src/main/java/nl/overheid/aerius/importer/ImaerImporter.java
Outdated
Show resolved
Hide resolved
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/base/GMLLegacyCodesSupplier.java
Outdated
Show resolved
Hide resolved
JornC
force-pushed
the
aer-4143-euroclass-warning
branch
2 times, most recently
from
b2bc815 to
262687f
Compare
Move removed vehicle code handling from post-processing to parsing. When a removed code is encountered in GML2VehicleUtil, the specific vehicle is converted to a CustomVehicle with zero emissions and a warning is added. - Add RemovedVehicleUtil for converting specific to custom vehicles - Add checkRemovedCode() to GMLConversionData - Change getRemovedCodes() to return Map<GMLLegacyCodeType, Set<String>> - Remove post-processing RemovedVehicleCodeConverter
JornC
force-pushed
the
aer-4143-euroclass-warning
branch
from
262687f to
b5071d1
Compare
Member
Author
|
(blocked by release not relevant here because it's on a later/snapshot version) |
BertScholten
requested changes
Jan 30, 2026
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/base/GMLConversionData.java
Outdated
Show resolved
Hide resolved
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/base/source/road/RemovedVehicleUtil.java
Outdated
Show resolved
Hide resolved
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/base/GMLConversionData.java
Outdated
Show resolved
Hide resolved
source/imaer-gml/src/test/java/nl/overheid/aerius/gml/base/source/road/GML2VehicleUtilTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for implementors to supply a list of removed euroclass codes, which, if they are encountered, will be converted from a specific vehicle source (now unsupported) to a custom vehicle source with 0 emission. Previously, these occurrences would result in an error, while now, they result in a warning, and a successfully converted source.