Skip to content

chore: remove unused min/max func#428

Open
cargoedit wants to merge 1 commit intoaergoio:developfrom
cargoedit:develop
Open

chore: remove unused min/max func#428
cargoedit wants to merge 1 commit intoaergoio:developfrom
cargoedit:develop

Conversation

@cargoedit
Copy link
Copy Markdown

Go 1.21 adds built-in functions min and max. https://tip.golang.org/doc/go1.21
Therefore, we can directly remove our own implementations and use the built-in function with the same names.

Signed-off-by: cargoedit <cargoedit@outlook.com>
@kroggen
Copy link
Copy Markdown
Member

kroggen commented Sep 25, 2025

This is all you have to add? Seriously?
It is not even adding anything, but rather removing.
This can only be automated

@cargoedit
Copy link
Copy Markdown
Author

This is all you have to add? Seriously? It is not even adding anything, but rather removing. This can only be automated

The Go standard library implements a method with the same name, so it can be removed. You can refer to the link above for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants