feat(154): clarify behavior if not supported #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was ambiguity around what to do if preconditions are not supported by an API. This guidance already existed in some form in the AEP, but raising it up front and center to help clarify universally what the behavior should be. In addition, renaming the aep from `/etags` and "resource freshness validation" to "preconditions", to match the IETF RFC.
rambleraptor
reviewed
Oct 1, 2025
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Can we define preconditions? The first section references ETags and then the guidance just sends you to the (very-long) RFC. Some information on precondition headers would go a long way.
toumorokoshi
force-pushed
the
yft/fix-269
branch
from
5e43018 to
be9bfa2
Compare
Member
Author
Added! |
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was ambiguity around what to do if preconditions are not supported by an API. This guidance already existed in some form in the AEP, but raising it up front and center to help clarify universally what the behavior should be.
In addition, renaming the aep from
/etagsand "resource freshness validation" to "preconditions", to match the IETF RFC.🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)./scripts/fix.py💝 Thank you!