Stubbing out the aep tooling list #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will update links after #231 is addressed
toumorokoshi
requested changes
Nov 3, 2024
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thank you! Mostly areas for discussion - I think I'm negotiable on all of them. Curious about your thoughts.
thanks, agree with all these suggestions and just layered in some minor tweaks to the suggestions. Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
toumorokoshi
approved these changes
Nov 10, 2024
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
A couple more nits, but otherwise LGTM! thank you.
toumorokoshi
force-pushed
the
repo-reorg
branch
from
d7f6c3f to
fc6d334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will update links after #231 is addressed
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply