Skip to content

Conversation

@toumorokoshi
Copy link
Member

create or update introduces a new pattern in addition to the existing flow of:

  1. getting a resource.
  2. if NOT_FOUND, send a create.
  3. if found, send an update.

In the future, this could be re-added as an Apply method, which would map to the appropriate REST method of PUT.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

@toumorokoshi toumorokoshi requested a review from a team as a code owner September 14, 2024 03:22
@rambleraptor
Copy link
Member

I'm in favor of this as long as the goal is to add an Apply method. If we don't add Apply long-term, this feels useful.

@toumorokoshi
Copy link
Member Author

Feedback offline from @rofrankel is to wait until apply is merged (issue tracked in #110)

@toumorokoshi
Copy link
Member Author

blocked on #248 - once that is merged, this will also merge.

create or update introduces a new pattern in addition
to the existing flow of:

1. getting a resource.
2. if NOT_FOUND, send a create.
3. if found, send an update.

In the future, this could be re-added as an Apply method,
which would map to the appropriate REST method of PUT.
@toumorokoshi toumorokoshi merged commit 28534cd into aep-dev:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants