refactor: use aep-lib-go #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing logic upstreamed to aep-lib-go.
aep-lib-go provides it's own representation of APIs. Using that the source of truth in the codebase, over the aepc-specific parsed service, will hopefully deduplicate code in the future by providing a single API representation among AEP codebases.
toumorokoshi
force-pushed
the
yft/refactor
branch
from
c531e42 to
6833085
Compare
linter has been updated to correctly identify resources, and there's some existing bugs. Disabling for now to move this quite painful refactor in. rule violations will be fixed in follow-up PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing logic upstreamed to aep-lib-go.
aep-lib-go provides it's own representation of
APIs. Using that the source of truth in the
codebase, over the aepc-specific parsed service,
will hopefully deduplicate code in the future
by providing a single API representation among
AEP codebases.