fix(oas, path): add _id suffix #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aep guidance is to add the _id suffix on all path elements. For consistency, adding the _id suffix to the pattern as well. Making this change also required propagating the snake_case convention to the resource singular and API conversion as well - without doing so, conversion logic is necessary to extract and generate the appropriate paths. This is aligned with the work to align with snake case across the board: aep-dev/aeps#320 This change is being made in lockstep with aep-dev/aeps#321 to update the guidance.
toumorokoshi
force-pushed
the
yft/id-suffix
branch
from
a71b26b to
b6756f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aep guidance is to add the _id suffix
on all path elements. For consistency, adding the _id
suffix to the pattern as well.
Making this change also required propagating the snake_case
convention to the resource singular and API conversion as well -
without doing so, conversion logic is necessary to extract and generate
the appropriate paths.
This is aligned with the work to align with snake case
across the board: aep-dev/aeps#320
This change is being made in lockstep with
aep-dev/aeps#321 to update the guidance.