Skip to content

feat: add explicit option to disable/enable instrument#44

Open
tgriesser wants to merge 1 commit intoaelbore:masterfrom
tgriesser:disable-instrument
Open

feat: add explicit option to disable/enable instrument#44
tgriesser wants to merge 1 commit intoaelbore:masterfrom
tgriesser:disable-instrument

Conversation

@tgriesser
Copy link
Copy Markdown

Had some code that I was looking to use this with, but it contained block(, which triggered the babel to run. Figured it'd be good to have a way to explicitly disable running the code through babel, so added instrument option to the config.

@bhousel
Copy link
Copy Markdown

bhousel commented Aug 5, 2021

Awesome, I just ran into this issue today as well, some of our test code that happened to contain ock( was triggering the issue.

The Babel transformer actually generates interop code containing require that won't work on an ESM project - this should maybe be a separate issue. But either way, making this behavior opt-in (or maybe matching on something better than ock( ) would be really helpful for us.

For the time being I've added this workaround:
rapideditor/rapid-sdk@f407a55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants