Skip to content

fix: Option.TokenExpiration should be number of seconds instead of Unix timestamp #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhangyoufu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Option.TokenExpiration should be number of seconds instead of Unix timestamp #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func main() {
opt := &registry.Option{
Certfile: crt,
Keyfile: key,
TokenExpiration: time.Now().Add(24 * time.Hour).Unix(), // 24hrs
TokenExpiration: (24 * time.Hour).Milliseconds() / 1000, // 24hrs
TokenIssuer: "Authz",
Authenticator: &exampleAuthenticator{}, // could be nil, meaning all users would be authenticated by default
}
Expand Down
2 changes: 1 addition & 1 deletion example/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func main() {
opt := &registry.Option{
Certfile: "/mnt/certs/RootCA.crt",
Keyfile: "/mnt/certs/RootCA.key",
TokenExpiration: time.Now().Add(24 * time.Hour).Unix(),
TokenExpiration: (24 * time.Hour).Milliseconds() / 1000,
TokenIssuer: "Authz",
Authenticator: &httpAuthenticator{},
}
Expand Down