Draft
Conversation
should we parameterize?
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
felickz
commented
Aug 1, 2024
| # Example: advanced-security/reusable-workflows/.github/dependency-review.yml@main | ||
| config-file: ${{ steps.config.outputs.config }} | ||
| comment-summary-in-pr: "always" | ||
| retry-on-snapshot-warnings: "true" #This will add a 120s delay on any repos without a snapshot |
Collaborator
Author
There was a problem hiding this comment.
Todo: parameterize - otherwise this will add 120s delay by default while it spin waits for a snapshot every 10s until 120s
Contributor
There was a problem hiding this comment.
So what happens if a snapshot never comes? Like for a Python or JS project
Collaborator
Author
There was a problem hiding this comment.
it will timeout after the default (over-rideable in the action)
Collaborator
Author
There was a problem hiding this comment.
@copilot allow the workflow caller to opt into these settings - passthrough those inputs via the caller and only if passed in then set on this workflow:
| feature | desc | values | default |
|---|---|---|---|
| retry-on-snapshot-warnings* | Enable or disable retrying the action every 10 seconds while waiting for dependency submission actions to complete. | true, false | false |
| retry-on-snapshot-warnings-timeout* | Maximum amount of time (in seconds) to retry the action while waiting for dependency submission actions to complete. | Any positive integer | 120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this the DR check happens too quickly to support any snapshot submissions happening concurrent outside this workflow.