Added birth control tracking to calendar #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Great work getting the one-click birth control tracking connected to the calendar, functionality is working and is a solid start for the future tracking system. A few notes before merging: There are merge conflicts in calendar.tsx and useMarkedDates.ts that need to be resolved. Some date-marking logic is duplicated, we should consolidate this into useMarkedDates so flow, symptoms, and birth control all pull from one consistent source. Make sure the final version matches the updated ephira UI patterns. Overall, great progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Reminder (for reviewers)
This PR requires a mobile build for both platforms
app.jsonversion has been updated and matches versioning formatActions->Manual EAS Expo Build->Run workflowdropdown -> Choose appropriate platform(s) ->Run workflow