split method - more accurate description #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At first I did not understand the meaning of this method from the documentation, and at first I thought that the address was simply broken into pieces of exponent bits. But looking at the code, I realized that it is generally intended for another. Apparently this method was used to divide the networks into subnets a exponent bits additionally? Then my comment more accurately reflects the meaning IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I did not understand the meaning of this method from the documentation, and at first I thought that the address was simply broken into pieces of exponent bits. But looking at the code, I realized that it is generally intended for another. Apparently this method was used to divide the networks into subnets a exponent bits additionally? Then my comment more accurately reflects the meaning IMHO.
And the target_length is not used in source. I think it's old removed variable. Please check up this!