Making the REAMDME.md a bit more precise and general to use for other people#1
Open
marvi3 wants to merge 8 commits intoadrian-rt:masterfrom
Open
Making the REAMDME.md a bit more precise and general to use for other people#1marvi3 wants to merge 8 commits intoadrian-rt:masterfrom
marvi3 wants to merge 8 commits intoadrian-rt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like your approach to make the whole project with just one script.
However I was facing some difficulties when running it and after fixing them I thought I could contribute to the repo b creating a pull request with them.
I changed the following:
More changes I had no time to fix for now: