Skip to content

Allow to use coma in numbers #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GCorbel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow to use coma in numbers #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f517684
Allow to use coma in numbers
GCorbel Nov 19, 2016
00f4696
Merge branch 'master' into master
offirgolan Jun 30, 2017
2e35d05
Merge branch 'master' into master
GCorbel Jul 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions addon/number.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ const {
* @param {String} attribute
*/
export default function validateNumber(value, options) {
if (typeof value === 'string') {
value = value.replace(/,/g, '.');
}

let numValue = Number(value);
let optionKeys = Object.keys(options);
let { allowBlank, allowNone = true, allowString, integer } = getProperties(options, ['allowBlank', 'allowNone', 'allowString', 'integer']);
Expand Down
5 changes: 4 additions & 1 deletion tests/unit/validators/number-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test('no options', function(assert) {
});

test('allow string', function(assert) {
assert.expect(6);
assert.expect(7);

options = {
allowString: true
Expand All @@ -35,6 +35,9 @@ test('allow string', function(assert) {
result = validate('22.22', cloneOptions(options));
assert.equal(processResult(result), true);

result = validate('22,22', cloneOptions(options));
assert.equal(processResult(result), true);

result = validate('test', cloneOptions(options));
assert.equal(processResult(result), 'This field must be a number');

Expand Down