Skip to content

fix(presence): fix doc and add option to allow empty string#145

Open
GreatWizard wants to merge 1 commit intoadopted-ember-addons:masterfrom
GreatWizard:fix/presence-empty-string
Open

fix(presence): fix doc and add option to allow empty string#145
GreatWizard wants to merge 1 commit intoadopted-ember-addons:masterfrom
GreatWizard:fix/presence-empty-string

Conversation

@GreatWizard
Copy link
Contributor

Problem

The current ignoreBlank option said it treats an empty string as not present.
But as you can see in the test, this exact use case throw an error.

Current solution

  • Add test about the failing use case
  • Add a new allowEmpty option to handle that specific use case and not break the current integration
  • Update the JSDoc accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant