import service instead of inject from '@ember/service' #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { dependentKeyCompat } from '@ember/object/compat'; | ||
| import { tracked } from '@glimmer/tracking'; | ||
| import { inject as service } from '@ember/service'; | ||
| import { service } from '@ember/service'; |
Collaborator
There was a problem hiding this comment.
this is a breaking change -- can you update this to the style of support mentioned in the deprecation guide?
thank you!!!
https://deprecations.emberjs.com/id/importing-inject-from-ember-service
Author
There was a problem hiding this comment.
Should be closer to acceptable now... still unsure about if it's correct changing on the earlier version 'test-app's
NullVoxPopuli
approved these changes
Jun 4, 2025
SergeAstapov
approved these changes
Jun 6, 2025
Author
|
@NullVoxPopuli @SergeAstapov, sorry for the delay. I have no experience with ember pre 4.x or any experience with cross version support really--not sure what to do about the failing 3.x pipes |
Collaborator
|
aye, that seems like a separate issue, and I don't think we need to worry about it in this PR. Thanks for submitting! |
NullVoxPopuli
merged commit c07560c
into
adopted-ember-addons:master
19 of 22 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #414