Skip to content
This repository was archived by the owner on Sep 27, 2021. It is now read-only.

Conversation

@vityukBogdan
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.703% when pulling 5029c1d on vityukBogdan:broadcast into 1d99b9a on adonisjs:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.703% when pulling 5029c1d on vityukBogdan:broadcast into 1d99b9a on adonisjs:develop.

@adonisjs adonisjs deleted a comment from thetutlage May 27, 2019
@RomainLanz
Copy link
Member

It seems that this change could break some code.
Therefore, it will not be merge right now

@thetutlage
Copy link
Member

Infact, the current behavior is correct. Here's why

const topic = Ws.getChannel('chat').topic('watercooler')

Now you have access to all the sockets subscribed to watercooler topic. When you say topic.broadcast(), you don't know which socket to ignore. So the message must go to all the sockets

@CodingDive
Copy link

I have a http controller that is using topic.broadcast(). I'm very surprised to see that it's broadcasting the event also to the client that sent the HTTP request. Why is that the case and how could I exclude the client that's connected to the topic who sent the HTTP request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants