This repository was archived by the owner on Sep 27, 2021. It is now read-only.
Fix cluster broadcast when emitting only to specified ids #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When I was playing with the cluster to implement PM2 support I realized that when using
Socket.emitTomethod, payload is sent to specified socket ids on current worker, but then broadcasted to other cluster workers and sent to all sockets - filtering of ids is not preserved. So I added these arguments to message broacasted by ClusterHop. Also I added an ability to specify ids ommited by broadcast. Examle:Types of changes
Checklist
Further comments
I will add tests just tell me if you are OK with the changes made. Thank you.