This repository was archived by the owner on Sep 27, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Extract serializing messages for ClusterHop to serializer and add conditional implementation when
process is managed by pm2 so messages can be handled by message bus in PM2 module.
See issue #58 for detailed explanation.
Types of changes
What types of changes does your code introduce?
Checklist
Further comments
Recieved and sent events need to have type when using PM2. I chose the name
adonis:hop. This event type needs to be used when listening and emitting messages on PM2 message bus. I wrote a simple PM2 module, which can be used for broadcasting messages. You can install it as follows:Also when I was testing if everything is working I found that
Channel.clusterBroadcastis calling non exisitng methodChannel.broadcast, which was renamed toChannel.broadcastPayloadin commit 5a3464c. So I fixed it in this PR.There is one more bug according to broadcasting to workers. When you use
Socket.emitTomethod, event is sent only to given IDs on current worker, but then broacasted and sent to ALL sockets for topic on other workers. I will send another PR to fix this issue.