This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Open
Conversation
Member
|
Hey @SergeiLomako! 👋 Could you please add a bit of context on your PR and not simply dropping some code changes? 😄 |
Author
|
Hi @RomainLanz! Sorry for not adding a description. I added url with query string and datetime to the logger. Also in the config, added the ability (ignoredUrls (type Array)) to ignore some URLs in the form of additional settings |
Member
|
Seems that tests aren't passing. Could you please fix your code? |
RomainLanz
approved these changes
Feb 28, 2019
leleuvilela
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.