Skip to content

Conversation

@skumar09
Copy link
Collaborator

  • NALA Automation test scripts for Merge Pdf verb

Resolves: MWPW-175430

Test URLs:

arugupta1992 and others added 2 commits September 25, 2025 23:09
…ng with edit pdf (#575)

Fetch target campaign for mboxid 'acom_unity_'< product >'_'< verb
>'_region'
Using alloy sdk(_satellite.track) for fetch call
Added Unit Test
Target code is present in a separate file experiment-provider.js for
optimisation
We should not send the variantId in payload if the variant fetch fails.
BE will provide the default URL in that case for pdf-editor
Added warning analytics to capture the failure during fetching
experiment data

Resolves: [MWPW-173563](https://jira.corp.adobe.com/browse/MWPW-173563)

Test URLs:
Before: https://stage--dc--adobecom.aem.live/acrobat/online/pdf-editor
After:
https://stage--dc--adobecom.aem.live/acrobat/online/pdf-editor?unitylibs=editPdf-ab

---------

Co-authored-by: rohitsahu <sahurohit9@gmail.com>
Co-authored-by: Rohit Sahu <rosahu@adobe.com>
Co-authored-by: Arushi Gupta <arugupta@arushis-mbp.corp.adobe.com>
Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 25, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 25, 2025

Page Scores Audits Google
📱 /?martech=off Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /?martech=off Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

skumar09 and others added 3 commits September 25, 2025 15:41
* Add support for lightroom workflow
* Add common util file for file chunking
* Unit tests
* Nala Tests

Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571)

**Test URLs:**
- Before:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off
- After:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=MWPW-180571&martech=off

**Testing Notes:**
**Lightroom testing**
1. Test with various size of jpeg files and make when the file is
greater than 10 MB file is uploaded in chunks
2. File type supported is jpeg/jpg
3. Max size supported is 40 MB
4. If you get 403 when landing on the product page please open this url
in browser in another tab
https://f0.lightroom.adobe.com/tkt/#magic=split-rocker
5. Clear your cookies and test in normal window and not in incognito. We
are seeing some issue on product page when testing incognito.
6. This is going to be a desktop only feature. Authors will most likely
achieve it by using MEP

**Photoshop Testing:**
1. As this PR is touching the code for workflow-upload, please do a
regression PS workflow too

Authoring Documentation:

https://wiki.corp.adobe.com/display/adobedotcom/CC+Upload+Configurator+for+Lightroom
Ruchika4 and others added 3 commits October 17, 2025 16:12
…585)

Update code to make function names generic as this workflow will now be
used for products other Photoshop. Following was updated:
* Renamed psApiConfig → apiConfig
* Renamed getPsApiConfig() → getApiConfig()
* Renamed unityConfig.psEndPoint → unityConfig.endPoint
* Renamed photoshopActionMaps() → executeActionMaps()
* Updated product tag resolution to use configuration-driven approach
from target-config.json for Lana logging
* All API endpoint references updated throughout the files
* Added additional analytics event for failures once uploading has
started
* Increase unit test coverage (workflow-upload - 94.68% ,
action-binder.js - 93.38%, upload-handler.js - 100%
<img width="1432" height="438" alt="Screenshot 2025-10-16 at 10 46 05
PM"
src="https://github.com/user-attachments/assets/28aab761-12aa-4768-8413-9cfae272eb44"
/>


Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571)

**Test URLs:**
- Before:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off
- After:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=lightroom-refactor&martech=off

---------

Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com>
Co-authored-by: rohitsahu <sahurohit9@gmail.com>
Co-authored-by: Rohit Sahu <rosahu@adobe.com>
Co-authored-by: Arushi Gupta <arugupta@arushis-mbp.corp.adobe.com>
Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
Co-authored-by: sigadamramesh <130433161+sigadamvenkata@users.noreply.github.com>
Co-authored-by: Santoshkumar Nateekar <santoshkumar.sn@gmail.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Fixing Nala tests for:
* Firefly
* Word-to-pdf

Resolves: [MWPW-182435](https://jira.corp.adobe.com/browse/MWPW-182435)

**Test URLs:**
- Before: https://main--unity--adobecom.aem.page/?martech=off
- After: https://ff-nala-fix--unity--adobecom.aem.page/?martech=off

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* Fix browser default behavior when image is drop outside of drop zone
* Don't let any drop happen outside of drop zone so that image doesn't
open in the whole browser taking over the page.

Resolves: [MWPW-182449](https://jira.corp.adobe.com/browse/MWPW-182449)

**Test URLs:**
- Before:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off
- After:
https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=drag-n-drop&martech=off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants