Skip to content

Conversation

@vipu0303
Copy link
Collaborator

@vipu0303 vipu0303 commented Sep 20, 2025

https://jira.corp.adobe.com/browse/MWPW-179252

  • Added changes to make pageConfig call and update the endpoint
  • Making all calls (including analytics) to the updated end point further
  • Made the method generic so that it can be called across different workflows
  • sending updated endpoint to slytherin for sending analytics to updated endpoint
  • send pageConfig analytics (both success and failure, changes done in slytherin code for this)
  • [ToDo] UTs are yet to be added

Corresponding Slytherin PR:
adobecom/dc#1295

Resolves: MWPW-179252

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@vipu0303 vipu0303 marked this pull request as draft September 22, 2025 10:54
@vipu0303 vipu0303 changed the title [MWPW-179252] Add pageConfig call for optimal endpoint [Draft] [MWPW-179252] Add pageConfig call for optimal endpoint Sep 22, 2025
subCode: ActionBinder.ERROR_MAP[errorMetaData.subCode] || errorMetaData.subCode || status,
desc: errorMetaData.desc || message || info || undefined,
},
logEndPoint: this.acrobatApiConfig?.acrobatEndpoint?.log,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slytherin (dc) side changes corresponding to this are in PR:
adobecom/dc#1295

upload_warn_delete_asset: -603,
validation_warn_validate_files: -604,
warn_fetch_experiment: -605,
warn_page_config_call_failed: -606,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if the dashboard query needs modification to start recording this. Actual modification to be done after the PR merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it may need dashboard modifications.

}
}

async checkandUpdatePageConfigEndpoint(updateConfigCallback, onFailure) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async checkandUpdatePageConfigEndpoint(updateConfigCallback, onFailure) {
async updateUnityEndpoint(updateConfigCallback, onFailure) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the name to fetchPageConfig.
The method now accepts unityEndpointSuccessCb and unityEndpointfailureCb and also returns the response body which make it future proof in case more info is being fetched from service in response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants