MWPW-179717 Milo preflight Insights: General Report download: Report does not contain issue details #5265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
KetakiD-Deshwandikar
changed the title
…takiD-Deshwandikar/milo into 179717-brokenlinks-seoreport
Contributor
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Contributor
|
Closing this PR due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-179717
Enhanced Milo Preflight insights to capture comprehensive broken link details in SEO reports, addressing missing issue information in current reports.
Modified validLinkFilter() in checks/seo.js to capture additional metadata for all links
Added metadata properties: tagType, position, linkTextOrImgAlt, visibility
Implemented getElementPosition() - identifies link location (NAV/FOOTER/CONTENT)
Implemented getTagType() - determines element type (Anchor/Image/IFrame)
Implemented isElementVisible() - checks element visibility status
Report now includes per-link details:
Note
Parameters such as ResponseCode, Redirected URL, and Redirected URL Status, locale can be extracted from the Milo Studio codebase.