Skip to content

Conversation

@skholkhojaev
Copy link
Contributor

@skholkhojaev skholkhojaev commented Dec 18, 2025

The ASO Preflight logic was not running on page load specifically the pages with disabled publish button, causing SEO results to get stuck in an infinite loading state when opening the Preflight modal.
This was beacuse getPreflightResults() being called after early return conditions in preflight-notification.js. If any of these condition were met (notification dismissed, overlay exists, publish button disabled, or sidekick closed), the function would exit before the API call was made.

Resolves: MWPW-185405

Testing

  1. Go to https://stage--da-bacom--adobecom.aem.page/products/campaign/audience-insights?milolibs=aso-preflight-page-load--milo--adobecom
  2. ASO is currently disabled. To test it open the dev tools, navigate to the preflightApi.js file and change the line 74 to const suite = 'ASO'
  3. Then Save the file and refresh the page
  4. Open Preflight -> SEO tab
  5. SEO results shoudl appear after ~5 seconds or a little longer

Test URLs:

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Dec 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skholkhojaev skholkhojaev requested a review from a team December 18, 2025 15:07
@github-actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants