[Preflight] ASO Preflight logic not running at page load #5261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASO Preflight logic was not running on page load specifically the pages with disabled publish button, causing SEO results to get stuck in an infinite loading state when opening the Preflight modal.
This was beacuse
getPreflightResults()being called after early return conditions inpreflight-notification.js. If any of these condition were met (notification dismissed, overlay exists, publish button disabled, or sidekick closed), the function would exit before the API call was made.Resolves: MWPW-185405
Testing
preflightApi.jsfile and change the line 74 toconst suite = 'ASO'Test URLs: