Skip to content

Conversation

@overmyheadandbody
Copy link
Contributor

@overmyheadandbody overmyheadandbody commented Dec 11, 2025

On mobile devices, additional logic is executed for the carousel, to ensure slides have a balanced height. However, this logic is currently able to execute even before images have finished loading. This PR waits for the images from the first slide to load before executing any additional height logic.

To reproduce the original issue, use a viewport below 900px and throttle the network via the Network or Performance tabs in Developer tools to 3G/Slow 4G.

Screenshots

Before After
Screenshot 2025-12-11 at 14 57 43 Screenshot 2025-12-11 at 14 58 02

Resolves: MWPW-184752

Test URLs:

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Dec 11, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions, knowing that you usually consider a lot of use-cases, those might already have been considered!

@mokimo
Copy link
Contributor

mokimo commented Dec 11, 2025

Thanks for the detailed answers and providing context - am fully on your side with your assumptions. We can still re-visit if QEs/others raise some issues.

@github-actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@biljana-cvijanovic biljana-cvijanovic self-assigned this Dec 15, 2025
Copy link
Contributor

@biljana-cvijanovic biljana-cvijanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants