-
Notifications
You must be signed in to change notification settings - Fork 212
[MWPW-184752] Ensure carousel first slide img load #5249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
mokimo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions, knowing that you usually consider a lot of use-cases, those might already have been considered!
3ba8b7e to
71d1339
Compare
|
Thanks for the detailed answers and providing context - am fully on your side with your assumptions. We can still re-visit if QEs/others raise some issues. |
|
Reminder to set the |
biljana-cvijanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated. Testing details https://jira.corp.adobe.com/browse/MWPW-184752
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
On mobile devices, additional logic is executed for the carousel, to ensure slides have a balanced height. However, this logic is currently able to execute even before images have finished loading. This PR waits for the images from the first slide to load before executing any additional height logic.
To reproduce the original issue, use a viewport below
900pxand throttle the network via the Network or Performance tabs in Developer tools to 3G/Slow 4G.Screenshots
Resolves: MWPW-184752
Test URLs: