-
Notifications
You must be signed in to change notification settings - Fork 211
MWPW-182328 modal hash #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
MWPW-182328 modal hash #5144
Conversation
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
Closing this PR due to inactivity. |
| expect(document.getElementById('milo')).not.to.exist; | ||
| }); | ||
|
|
||
| it('Closes a modal on manual hash chagne', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| it('Closes a modal on manual hash chagne', async () => { | |
| it('Closes a modal on manual hash change', async () => { |
|
@zagi25 , I am seeing issues with hashes containing from_ims=true: Modal1 and Modal2 break: no modals open after clicking CTAs Here is a patch to add the fixes: |
Issue: If
window.location.hashis changed manually, modal stays open resulting in possibility to open another modal on top of already open modal or scrolling the page to the heading while modal is openResolves: MWPW-182328
Test URLs: