generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 212
MWPW-178376: Improve variant layout handling #4730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7e8d75c
improve variant layout handling
Axelcureno a446ba7
Merge branch 'MWPW-178376' of github.com:adobecom/milo into MWPW-178376
Axelcureno 7478445
Merge branch 'stage' into MWPW-178376
Axelcureno 101ff9d
Merge branch 'stage' into MWPW-178376
Axelcureno c710211
fix: call insertVariantStyle in connectedCallbackHook
Axelcureno 1f15f69
fix: make insertVariantStyle synchronous for immediate style application
Axelcureno fe5b9ea
Merge branch 'stage' into MWPW-178376
Axelcureno c7562bc
fix: revert to original <style> element approach for global and varia…
Axelcureno 9bb4a56
fix: use constructor name as styleMap key to prevent duplicate styles
Axelcureno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.