Skip to content

Conversation

@bozojovicic
Copy link
Contributor

@bozojovicic bozojovicic commented Dec 18, 2025

Resolves https://jira.corp.adobe.com/browse/MWPW-175016
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Tacocat PR https://git.corp.adobe.com/wcms/tacocat.js/pull/676

New template 'Promotion Strikethrough Price' added for PROMOTION offers

Screenshot 2025-12-18 at 15 30 49

Test pages :
Milo OST https://mwpw175016promost--milo--bozojovicic.aem.page/tools/ost?maslibs=MWPW-175016&token=<>
MAS Studio OST https://mwpw-175016--mas--adobecom.aem.live/studio.html#page=content&path=sandbox
Milo page with ST promo price https://mwpw175016promost--milo--bozojovicic.aem.page/drafts/bozo/st-promo?maslibs=MWPW-175016

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-175016 December 18, 2025 15:13 Inactive
@bozojovicic bozojovicic marked this pull request as ready for review December 18, 2025 15:17
Copy link
Contributor

@honstar honstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afmicka afmicka added the do not merge PR should not be merged yet label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge PR should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants