MWPW-178376: Improve variant layout handling #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced variant registration logic with WeakMap for better state management - Cleaned up style application process to ensure proper handling of CSSStyleSheet and fallback to style elements when necessary - Adjusted variable names for consistency and clarity - Avoids duplicate style injection
The variant-layout and variants.js changes are made to the deprecated web-components folder which is not used in tests. Tests use Milo's code instead. Reverting these changes to focus on the Milo dependency update which includes the new subcollection test.
The latest Milo stage commit (15923a43d15f...) introduced a breaking change that uses query string parameters (?filter=) instead of hash parameters (#filter=), causing all MAS tests to fail. Reverting to the previous working commit (85c42131...) until the Milo issue is resolved.
Contributor
|
@Axelcureno , don't we need the |
Restore the variant layout enhancements that improve stylesheet caching: - Use constructor.name as style key instead of variant name for better isolation - Add WeakMap for tracking variant state per card - Implement stylesheet caching to avoid duplicate CSSStyleSheet instances - Improve browser compatibility with proper fallback handling
Member
Author
yes, I accidentaly reverted the changes but have now brought them back. Thanks for the heads up @honstar. |
honstar
approved these changes
Dec 17, 2025
mirafedas
approved these changes
Dec 22, 2025
mirafedas
requested changes
Dec 22, 2025
Contributor
mirafedas
left a comment
mirafedas
left a comment
There was a problem hiding this comment.
Could you please add unit tests for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-178376
Related Milo PR: adobecom/milo#4730
Test URL: https://main--cc--adobecom.aem.page/creativecloud/plans?maslibs=mwpw-178376