-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-183500 - [Prod] AH | Try/Buy Widget M@S card is not appearing properly in Dark mode compared to other two cards #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
seanchoi-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For code, looks good in overall.
Please take a look the failing check.
Thanks for the review @seanchoi-dev . The test failure is being addressed in the milo repository, see adobecom/milo#5230. This fix is already on stage, the failures will disappear once it goes to prod. |
…operly in Dark mode compared to other two cards - adjusted background color to match figma for AH dark mode - added gradient border color option and support
|
@honstar Could you please link this Jira in the PR description: https://jira.corp.adobe.com/browse/MWPW-183500 ? |
Thanks, I must have accidentally copied the wrong JIRA link while checking the history of the AH try-buy-widget variant! I've updated the PR title and description with the correct link. |
|
For QA: please use https://mwpw-165518--mas--adobecom.aem.live/web-components/docs/adobe-home.html?theme=dark and ignore the wrong JIRA ticket branch name, my mistake. The new gradient border card on this docs page can be inspected here: https://mwpw-165518--mas--adobecom.aem.live/studio.html#fragmentId=df508462-c9bd-4ec8-8b8a-70e502228c18&page=fragment-editor&path=nala |
|
@honstar please check the styling for the new gradient fragment in the light mode. The label is not visible (white) on the black CTA https://mwpw-165518--mas--adobecom.aem.live/web-components/docs/adobe-home.html?theme=light
|
|
@afmicka : the issue with the black cta not showing the label has been fixed (thanks to @yesil 👍 ): https://mwpw-165518--mas--adobecom.aem.live/web-components/docs/adobe-home.html?theme=light |

Resolves https://jira.corp.adobe.com/browse/MWPW-183500
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: