-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-183410: Version page #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # studio/src/aem/aem.js
# Conflicts: # studio/libs/swc.js # studio/src/editor-panel.js # studio/test/editor-panel.test.html # web-components/test/merch-card-collection.test.html
|
@afmicka , Once we have the API, we can also add this feature. For copy link, I can still add it but not even sure if it is needed. (For prod, it is just a placeholder and not working.) |
Compare history:
|
# Conflicts: # studio/libs/swc.js # studio/src/studio.js
nala/studio/version-page.page.js
Outdated
| this.breadcrumbCurrent = page.locator('version-page sp-breadcrumb-item').last(); | ||
|
|
||
| // Header section | ||
| this.header = page.locator('version-page .version-page-header'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing these? The failing selectors need to be updated to the correct values, not removed. There is also no need to remove the checks nor the test just so that Nala becomes green.
Also, please don't keep run nala label present with so many commits. We have introduced the label not to run the tests constantly. Please, check the test execution locally. Let me know if you need help setting that up
|
@seanchoi-dev Any reason why secure transaction label is not visible in the card preview in the compare panel? It is there (either as a value or placeholder) in the editor, but once in compare view the show secure transaction is listed as a change but is not visible on neither of fragments that are being compared (it should be visible at least on one). Also, as a change there is listed "variations" (without a value though an invisible field). If a user restores to that previous version, the variations info is removed. The fragments themselves are not deleted from those locales where variations were created but they are not linked anymore. Should that be the case? I guess the variations should either be deleted from the locales or kept as a link with restoring. @npeltier any thoughts?
|






Resolves https://jira.corp.adobe.com/browse/MWPW-183410
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: