Skip to content

Conversation

@seanchoi-dev
Copy link
Contributor

Resolves https://jira.corp.adobe.com/browse/MWPW-183410
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

# Conflicts:
#	studio/libs/swc.js
#	studio/src/editor-panel.js
#	studio/test/editor-panel.test.html
#	web-components/test/merch-card-collection.test.html
@seanchoi-dev
Copy link
Contributor Author

@afmicka ,
For number 1, I disabled the edit name/comment feature for now since there is no API support for it now.
There is ticket for it and I asked them today if they can escalate it; they will include the ticket second sprint of 2026:
https://workfront.slack.com/archives/C03L9PP8HNH/p1759423060762399

Once we have the API, we can also add this feature.

For copy link, I can still add it but not even sure if it is needed. (For prod, it is just a placeholder and not working.)

@afmicka
Copy link
Collaborator

afmicka commented Dec 19, 2025

@seanchoi-dev

  1. Nala issues are not resolved, you have not updated the selectors that tests are not finding during executions. They are not correct, need to be updated. Left a comment above
    the failing run https://github.com/adobecom/mas/actions/runs/20366215866/job/58521798336?pr=453.
    Please tun them locally on your branch to check whether you have really resolved them. Let me know if you need help with this
    npm run nala branch MWPW-183410 @version

  2. When user navigates to the Fragments table (content page) directly from the history panel (not editor), the fragment id remains in the url. Should be removed the same way when user navigates from editor to the content page

Screenshot 2025-12-19 at 09 57 37
  1. Wide and super wide plans cards are shown as single width cards in the compare version panel.

Editor:
Screenshot 2025-12-19 at 10 54 24

Compare history:

Screenshot 2025-12-19 at 10 54 46

@afmicka afmicka removed the run nala label Dec 19, 2025
this.breadcrumbCurrent = page.locator('version-page sp-breadcrumb-item').last();

// Header section
this.header = page.locator('version-page .version-page-header');
Copy link
Collaborator

@afmicka afmicka Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing these? The failing selectors need to be updated to the correct values, not removed. There is also no need to remove the checks nor the test just so that Nala becomes green.

Also, please don't keep run nala label present with so many commits. We have introduced the label not to run the tests constantly. Please, check the test execution locally. Let me know if you need help setting that up

@afmicka afmicka removed the run nala label Dec 24, 2025
@afmicka
Copy link
Collaborator

afmicka commented Dec 24, 2025

@seanchoi-dev Any reason why secure transaction label is not visible in the card preview in the compare panel? It is there (either as a value or placeholder) in the editor, but once in compare view the show secure transaction is listed as a change but is not visible on neither of fragments that are being compared (it should be visible at least on one).

Also, as a change there is listed "variations" (without a value though an invisible field). If a user restores to that previous version, the variations info is removed. The fragments themselves are not deleted from those locales where variations were created but they are not linked anymore. Should that be the case? I guess the variations should either be deleted from the locales or kept as a link with restoring. @npeltier any thoughts?

Screenshot 2025-12-24 at 15 34 52 Screenshot 2025-12-24 at 15 35 13

There were en_CA and en_AU variations before restoring
Screenshot 2025-12-24 at 15 52 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants