Skip to content

MWPW-182614: apply corrector to mas-repository apis #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3ch023 merged 4 commits into from
Nov 13, 2025
Merged

MWPW-182614: apply corrector to mas-repository apis #430

3ch023 merged 4 commits into from
Nov 13, 2025

Conversation

@yesil
Copy link
Contributor

@yesil yesil commented Nov 13, 2025 •
edited by 3ch023
Loading

Resolves https://jira.corp.adobe.com/browse/MWPW-182614
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 13, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@yesil yesil changed the title Mwpw 182614 2 MWPW-182614: apply corrector to mas-repository apis Nov 13, 2025
npeltier
npeltier approved these changes Nov 13, 2025
View reviewed changes
io/www/src/fragment/transformers/corrector.js Outdated
import { logDebug } from '../utils/log.js';
const DATA_EXTRA_OPTIONS_REGEX = /data-extra-options="(\{[^}]*\})"/g;

const VALID_SURFACES = ['adobe-home', 'sandbox', 'ccd'];
Copy link
Contributor

@npeltier npeltier Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VALID surfaces? i would call them EXTRA_OPTION_SURFACES or something, no?

@3ch023 3ch023 merged commit fc501f1 into main Nov 13, 2025
8 of 9 checks passed
@3ch023 3ch023 deleted the MWPW-182614-2 branch November 13, 2025 16:49
Axelcureno pushed a commit that referenced this pull request Dec 3, 2025
@yesil @Axelcureno
MWPW-182614: apply corrector to mas-repository apis (#430)
50884e3 
* MWPW-182614: apply corrector to mas-repository apis

so that editor works as expected

* rename constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npeltier npeltier npeltier approved these changes

@3ch023 3ch023 3ch023 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yesil @npeltier @3ch023