Skip to content

Conversation

@TsayAdobe
Copy link
Contributor

Four Jupyter Notebooks for importing and managing merch cards.

Resolves https://jira.corp.adobe.com/browse/MWPW-180917
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Copy link
Contributor

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@Blainegunn Blainegunn requested a review from npeltier November 4, 2025 20:10
@Roycethan
Copy link
Collaborator

Roycethan commented Nov 5, 2025

@TsayAdobe

  1. Possible to migrate aria-label from share point to M@S ?
    ex: In below the values after the Pipe - [ |Get free app - Adobe Express - Individuals , |Learn more about Adobe Express ....etc....
image
  1. Fred has a ask in ticket about updating "Fragment Title" and "Fragment description" as well

cc @fwelterlin

@Roycethan Roycethan self-requested a review November 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants