-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-173542: add qa workspace for io/www #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, can you do the following:
- make io-deploy configurable and just deploying to one configurable aio env, with configurable secret,
- make io-tests configurable and just testing against a configurable aio env,
- create io-pr workflow that defined target env as follows: env if secrets are found, qa otherwise, then call io-deploy & io-tests against it
- create io-merge workflow that uses io-deploy & io test against stage, then io-deploy against prod
c87d352 to
7510a95
Compare
.github/workflows/io-merge.yaml
Outdated
| ODIN_ORIGIN_ENDPOINT: ${{ secrets.ODIN_ORIGIN_ENDPOINT }} | ||
| OST_WRITE_API_KEY: ${{ secrets.OST_WRITE_API_KEY }} | ||
| WCS_CDN_ENDPOINT: ${{ secrets.WCS_CDN_ENDPOINT }} | ||
| WCS_ORIGIN_ENDPOINT: ${{ secrets.WCS_ORIGIN_ENDPOINT }} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a newline at the end of the file
.github/workflows/io-merge.yaml
Outdated
| ODIN_ORIGIN_ENDPOINT: ${{ secrets.ODIN_ORIGIN_ENDPOINT }} | ||
| OST_WRITE_API_KEY: ${{ secrets.OST_WRITE_API_KEY }} | ||
| WCS_CDN_ENDPOINT: ${{ secrets.WCS_CDN_ENDPOINT }} | ||
| WCS_ORIGIN_ENDPOINT: ${{ secrets.WCS_ORIGIN_ENDPOINT }} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also wanted to run tests after deploy to prod, no? and if they fail send an email or something. but it could be a separate, next ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i see not that io-pr will run those tests, although it looks like it will not wait enough time for deploy, no?
.github/workflows/io-pr.yaml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to trigger it on push to main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhhh i see now.. so it will run tests after push to main, but won't deploy.
tbh i find it a bit confusing but it works i guess :D
do not run io-pr when pr is merged
Resolves https://jira.corp.adobe.com/browse/173542
Changing io-tests and io-deploy actions. io-tests action will deploy and test on a newly created workspace qa, on merge io-deploy will now deploy to stage - run tests, deploy to prod run tests
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Test URLs: