Skip to content

Conversation

@markovicpredrag1209
Copy link
Contributor

@markovicpredrag1209 markovicpredrag1209 commented May 19, 2025

Resolves https://jira.corp.adobe.com/browse/173542

Changing io-tests and io-deploy actions. io-tests action will deploy and test on a newly created workspace qa, on merge io-deploy will now deploy to stage - run tests, deploy to prod run tests

QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented May 19, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented May 19, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can you do the following:

  • make io-deploy configurable and just deploying to one configurable aio env, with configurable secret,
  • make io-tests configurable and just testing against a configurable aio env,
  • create io-pr workflow that defined target env as follows: env if secrets are found, qa otherwise, then call io-deploy & io-tests against it
  • create io-merge workflow that uses io-deploy & io test against stage, then io-deploy against prod

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 08:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 08:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 08:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 08:21 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 08:25 Inactive
Predrag Markovic added 2 commits May 28, 2025 10:38
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 15:16 Inactive
Predrag Markovic added 2 commits May 28, 2025 17:33
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-173542 May 28, 2025 15:48 Inactive
ODIN_ORIGIN_ENDPOINT: ${{ secrets.ODIN_ORIGIN_ENDPOINT }}
OST_WRITE_API_KEY: ${{ secrets.OST_WRITE_API_KEY }}
WCS_CDN_ENDPOINT: ${{ secrets.WCS_CDN_ENDPOINT }}
WCS_ORIGIN_ENDPOINT: ${{ secrets.WCS_ORIGIN_ENDPOINT }} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a newline at the end of the file

ODIN_ORIGIN_ENDPOINT: ${{ secrets.ODIN_ORIGIN_ENDPOINT }}
OST_WRITE_API_KEY: ${{ secrets.OST_WRITE_API_KEY }}
WCS_CDN_ENDPOINT: ${{ secrets.WCS_CDN_ENDPOINT }}
WCS_ORIGIN_ENDPOINT: ${{ secrets.WCS_ORIGIN_ENDPOINT }} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also wanted to run tests after deploy to prod, no? and if they fail send an email or something. but it could be a separate, next ticket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i see not that io-pr will run those tests, although it looks like it will not wait enough time for deploy, no?

on:
push:
branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to trigger it on push to main?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh i see now.. so it will run tests after push to main, but won't deploy.
tbh i find it a bit confusing but it works i guess :D

@npeltier npeltier merged commit 0ed77df into main Jun 9, 2025
9 checks passed
@npeltier npeltier deleted the MWPW-173542 branch June 9, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants