Skip to content

Conversation

@bozojovicic
Copy link
Contributor

@bozojovicic bozojovicic commented Apr 15, 2025

Plans card for students tab. Will be used outside card collection. Requested width 568px.
Authored in MAS Studio with new variant "Plans students".

Resolve MWPW-164493

Test page mwpw-164493--mas--adobecom.aem.live/studio.html?milolibs=mwpw164493students--milo--bozojovicic#path=sandbox&page=content&query=78856cda-ba13-424d-ac46-be79ac6545cb

Milo PR milo/pull/3933

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 15, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 15, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesil @bozojovicic has the usage of a different variant for student card been discussed?

i guess it's a bit late anyway

@afmicka
Copy link
Collaborator

afmicka commented May 5, 2025

@bozojovicic what is the purpose of Size field for students card if there is one size only? Should we hide that field on the editor for plans students variant? cc: @yesil @npeltier

Screenshot 2025-05-05 at 13 13 20

Not sure about other fields like whatsincluded, quantity selector, callout... they might be needed though

@afmicka
Copy link
Collaborator

afmicka commented May 5, 2025

@bozojovicic please take a look why Stock checkbox and Secure transaction are not showing up on Students card in milo. On this page are freshly created plans individuals and plans students cards:
https://main--milo--adobecom.aem.page/drafts/mili/plans-cards

@afmicka
Copy link
Collaborator

afmicka commented May 19, 2025

@bozojovicic cards are not loading in FR locale, IO check is failing. Could you please take look? Maybe was a temporary glitch and needs re-run
https://main--milo--adobecom.hlx.live/libs/features/mas/docs/ccd.html?mas-io-url=https%3A%2F%2F14257-merchatscale-Stage.adobeioruntime.net%2Fapi%2Fv1%2Fweb%2FMerchAtScale&locale=fr_FR

@afmicka afmicka merged commit 6ad6a56 into main May 20, 2025
7 checks passed
@afmicka afmicka deleted the MWPW-164493 branch May 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants