-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-164493 [Plans] Merch card for Plans page students tab #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
npeltier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesil @bozojovicic has the usage of a different variant for student card been discussed?
i guess it's a bit late anyway
|
@bozojovicic what is the purpose of Size field for students card if there is one size only? Should we hide that field on the editor for plans students variant? cc: @yesil @npeltier
Not sure about other fields like whatsincluded, quantity selector, callout... they might be needed though |
|
@bozojovicic please take a look why Stock checkbox and Secure transaction are not showing up on Students card in milo. On this page are freshly created plans individuals and plans students cards: |
|
@bozojovicic cards are not loading in FR locale, IO check is failing. Could you please take look? Maybe was a temporary glitch and needs re-run |

Plans card for students tab. Will be used outside card collection. Requested width 568px.
Authored in MAS Studio with new variant "Plans students".
Resolve MWPW-164493
Test page
mwpw-164493--mas--adobecom.aem.live/studio.html?milolibs=mwpw164493students--milo--bozojovicic#path=sandbox&page=content&query=78856cda-ba13-424d-ac46-be79ac6545cbMilo PR milo/pull/3933
Test URLs: