Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@express-milo-merge-bot
Copy link
Contributor

@express-milo-merge-bot express-milo-merge-bot bot commented Dec 3, 2025

Summary

This is an automated merge of the following PRs to stage:

Changes in this release

Test URLs

Environment URL
Before https://main--express-milo--adobecom.aem.page/express/
After https://stage--express-milo--adobecom.aem.page/express/?martech=off

Verification Steps

Please verify:

  1. All PRs listed above have been properly merged
  2. The stage environment is accessible and functioning
  3. No unexpected changes are present

Potential Regressions

The following URLs should be tested:

Additional Notes

This PR was automatically created by the merge-to-stage workflow.

hadobe and others added 21 commits November 13, 2025 12:44
…essibility controls

- Replace div with role=button with semantic button element in media.js
- Add CSS reset styles to maintain visual appearance
- Remove duplicate cursor property in styles.css
- Improve accessibility compliance for video controls
- Maintain keyboard navigation and ARIA attributes
…ling

- Replace :focus with :focus-visible for modern focus management
- Remove redundant keyboard event handler (native button handles Space/Enter)
- Improve accessibility UX with better focus indication
- Reduce code complexity by leveraging semantic button behavior
- Add comprehensive tests for createAccessibilityVideoControls function
- Test button element creation and semantic HTML
- Verify ARIA attributes and state management
- Test video event handling and accessibility features
- Improve test coverage for media utility functions
…lity button

- Remove tabindex from video element to prevent native browser play/pause on spacebar
- Replace addAnimationToggle with direct click handler for button element
- Prevents spacebar trap - button uses native Space/Enter, unfocused spacebar scrolls page
- Maintains backward compatibility - addAnimationToggle unchanged for div elements
- Merge stage's comprehensive media.js tests with our createAccessibilityVideoControls tests
- Removed tests that require external imports causing async errors
- Functionality is better tested with manual testing and Nala tests
- All other media.js tests passing (991 total)
- Add conditional check in ax-marquee test to skip when video controls don't exist
- Add skip logic for pages without ax-marquee block (e.g., /express/create uses grid-marquee)
- Add Nala test for frictionless-quick-action remove-background variant
- Add video controls keyboard accessibility verification (spacebar trap fix)
- Tests verify proper button element, ARIA attributes, and keyboard navigation
- Add conditional check to skip test when ax-marquee block doesn't exist
- Fixes failures on pages like /express/create that use grid-marquee instead
- Wrap gotoURL calls in try-catch to handle HTTP/2 errors gracefully
- Skip tests when pages fail to load (e.g., /express/nonprofits INTERNAL_ERROR)
- Prevents test failures due to server-side issues
Co-authored-by: Shairil Kansal <shairilk@adobe.com>
Co-authored-by: Haris Bijli <all46558@adobe.com>
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 3, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@github-actions github-actions bot added the Ready for Review Ready for peer review. label Dec 3, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 3, 2025

Page Scores Audits
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.83%. Comparing base (c977780) to head (ef2ec70).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
express/code/blocks/ax-marquee/ax-marquee.js 14.28% 18 Missing ⚠️
express/code/scripts/utils/media.js 61.90% 8 Missing ⚠️
...tionless-quick-action/frictionless-quick-action.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   70.83%   70.83%   -0.01%     
==========================================
  Files         109      109              
  Lines       25446    25463      +17     
==========================================
+ Hits        18025    18036      +11     
- Misses       7421     7427       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@express-milo-merge-bot
Copy link
Contributor Author

Cannot merge to main due to failing or in-progress checks:

  • aem-psi-check: failure
  • build (20.x): failure

@express-milo-merge-bot
Copy link
Contributor Author

Stage to Main PR #828 is still open. Skipping merge to stage until it is resolved.

@fullcolorcoder fullcolorcoder deployed to express_pr_merge December 9, 2025 16:29 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Approved QA testing has been completed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants