Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@yeibercano
Copy link
Collaborator

@yeibercano yeibercano commented Nov 6, 2025

Summary

Fix tests by adding networkidle wait and increased timeout.

Potentially introduced here: #693


Jira Ticket

Resolves: MWPW-181665


Test URLs

Env URL
Before https://main--express-milo--adobecom.aem.page/express/
After https://nala-grid-marquee--express-milo--adobecom.aem.page/express/?martech=off

Verification Steps

  • Steps to reproduce the issue or view the new feature.
  • What to expect before and after the change.

Potential Regressions

  • https://--express-milo--adobecom.aem.live/express/?martech=off

Additional Notes

(If applicable) Add context, related PRs, or known issues here.

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 6, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@yeibercano
Copy link
Collaborator Author

Screenshot 2025-11-06 at 1 15 09 PM

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 6, 2025

Page Scores Audits
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.85%. Comparing base (580aee2) to head (5d053aa).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #758      +/-   ##
==========================================
- Coverage   70.86%   70.85%   -0.01%     
==========================================
  Files         108      108              
  Lines       24744    24744              
==========================================
- Hits        17535    17533       -2     
- Misses       7209     7211       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yeibercano yeibercano marked this pull request as ready for review November 6, 2025 21:32
@github-actions github-actions bot added the Ready for Review Ready for peer review. label Nov 6, 2025
@yeibercano yeibercano requested a review from hadobe November 6, 2025 21:32
@hadobe hadobe added QA Approved QA testing has been completed. and removed Ready for QA labels Dec 2, 2025
@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

5 similar comments
@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot
Copy link
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Design Review Not Required QA Approved QA testing has been completed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants