Skip to content

Conversation

Ruchika4 and others added 4 commits October 29, 2025 09:36
* pdf ai verb

* update icon path

* demo path

* go url

* Update acrobat/blocks/verb-widget/verb-widget.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…1312)

* fix tooltip

* fix tooltip

* fix tooltip

* remove redundant css

* optimize
@aem-code-sync
Copy link

aem-code-sync bot commented Nov 3, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 3, 2025

Page Scores Audits Google
📱 /acrobat/online/pdf-ai?unitylibs=stage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /acrobat/online/pdf-ai?unitylibs=stage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.


🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

window.location = new URL('https://www.adobe.com/acrobat/online/test');


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');


🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

window.location = new URL('https://localhost:2000/acrobat/online/test');


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.

reviewdog suggestion errorGitHub comment range and suggestion line range must be same. L9-L9 v.s. L1-L9

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.

reviewdog suggestion errorGitHub comment range and suggestion line range must be same. L10-L10 v.s. L1-L10

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/order> reported by reviewdog 🐶
https://main--milo--adobecom.aem.live/libs/utils/utils.js import should occur before import of ../../helpers/waitfor.js

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.

reviewdog suggestion errorGitHub comment range and suggestion line range must be same. L9-L9 v.s. L1-L9

'../../../acrobat/blocks/verb-widget/verb-widget.js'
);
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.

Comment on lines 5 to +6
import { delay } from '../../helpers/waitfor.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/order> reported by reviewdog 🐶
https://main--milo--adobecom.aem.live/libs/utils/utils.js import should occur before import of ../../helpers/waitfor.js

Suggested change
import { delay } from '../../helpers/waitfor.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
import { delay } from '../../helpers/waitfor.js';

import sinon from 'sinon';
import { delay } from '../../helpers/waitfor.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js';
import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.

${'main--dc--adobecom.aem.live'}
${'stage--dc--adobecom.hlx.page'}
`('ContentSecurityPolicy for stage', async ({ hostname }) => {
window.location = new URL(`https://${hostname}/acrobat/online/test`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 123. Maximum allowed is 100.

errorString = JSON.stringify(err.detail?.wrappedException, Object.getOwnPropertyNames(err.detail?.wrappedException));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'delay' is defined but never used.

import { delay, waitForElement } from '../../helpers/waitfor.js';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.

import { delay, waitForElement } from '../../helpers/waitfor.js';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

}
const placeholdersText = await readFile({ path: './mocks/placeholders.json' });

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.

block.dispatchEvent(new CustomEvent('unity:track-analytics', {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"

import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.

@Ruchika4
Copy link
Collaborator Author

Ruchika4 commented Nov 3, 2025

All the eslint failures are in test files and are not part of the code changes done in the release PR. they will be addressed separately.

@Ruchika4 Ruchika4 changed the title DC MILO Release 0.2545 DC MILO Release 0.2546 Nov 5, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);


🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

window.location = new URL('https://www.adobe.com/acrobat/online/test');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

window.location = new URL('https://localhost:2000/acrobat/online/test');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all

window.location = new URL('https://localhost:2000/acrobat/online/test');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('http-equiv')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.hasAttribute('content')).toBe(true);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.

expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy');

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.43%. Comparing base (4ef150b) to head (bb9579f).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   85.77%   85.43%   -0.34%     
==========================================
  Files          44       45       +1     
  Lines        7151     7589     +438     
==========================================
+ Hits         6134     6484     +350     
- Misses       1017     1105      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ruchika4 Ruchika4 merged commit ba44f30 into main Nov 10, 2025
212 of 228 checks passed
@aem-code-sync aem-code-sync bot temporarily deployed to sidekick-publish-update November 10, 2025 23:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants