-
Notifications
You must be signed in to change notification settings - Fork 48
DC MILO Release 0.2546 #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC MILO Release 0.2546 #1313
Conversation
* pdf ai verb * update icon path * demo path * go url * Update acrobat/blocks/verb-widget/verb-widget.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* update alt value * fix eslint issue
…1312) * fix tooltip * fix tooltip * fix tooltip * remove redundant css * optimize
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
| let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
| expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L9-L9 v.s. L1-L9| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.
| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L10-L10 v.s. L1-L10| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/order> reported by reviewdog 🐶https://main--milo--adobecom.aem.live/libs/utils/utils.js import should occur before import of ../../helpers/waitfor.js
| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.
| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/first> reported by reviewdog 🐶
Import in body of module; reorder to top.
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L9-L9 v.s. L1-L9| '../../../acrobat/blocks/verb-widget/verb-widget.js' | ||
| ); | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.
| import { delay } from '../../helpers/waitfor.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/order> reported by reviewdog 🐶https://main--milo--adobecom.aem.live/libs/utils/utils.js import should occur before import of ../../helpers/waitfor.js
| import { delay } from '../../helpers/waitfor.js'; | |
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | |
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; | |
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; | |
| import { delay } from '../../helpers/waitfor.js'; |
| import sinon from 'sinon'; | ||
| import { delay } from '../../helpers/waitfor.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.hlx.live/libs/utils/utils.js'; | ||
| import { getConfig, setConfig } from 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module 'https://main--milo--adobecom.aem.live/libs/utils/utils.js'.
| ${'main--dc--adobecom.aem.live'} | ||
| ${'stage--dc--adobecom.hlx.page'} | ||
| `('ContentSecurityPolicy for stage', async ({ hostname }) => { | ||
| window.location = new URL(`https://${hostname}/acrobat/online/test`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'delay' is defined but never used.
| import { delay, waitForElement } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
| import { delay, waitForElement } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
| window.lana = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/test/blocks/verb-widget/verb-widget-no-svg.test.js
Lines 30 to 31 in 64f7ed7
| } | |
| const placeholdersText = await readFile({ path: './mocks/placeholders.json' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
| block.dispatchEvent(new CustomEvent('unity:track-analytics', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
| })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
| import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
| let hostnameGetter; |
|
All the eslint failures are in test files and are not part of the code changes done in the release PR. they will be addressed separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
| let url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| window.location = new URL('https://localhost:2000/acrobat/online/test'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| window.location = new URL('https://localhost:2000/acrobat/online/test'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
- Coverage 85.77% 85.43% -0.34%
==========================================
Files 44 45 +1
Lines 7151 7589 +438
==========================================
+ Hits 6134 6484 +350
- Misses 1017 1105 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
DC MILO Release 0.2546
PRs
Test URLs
Before - https://main--dc--adobecom.aem.live/acrobat/online/pdf-ai?unitylibs=stage
After - https://stage--dc--adobecom.aem.live/acrobat/online/pdf-ai?unitylibs=stage