MWPW-183578 PrM x YT gallery #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
148
to
149
|
|
||
|
|
There was a problem hiding this comment.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
Suggested change
added 2 commits
December 18, 2025 12:38
Comment on lines
203
to
204
|
|
||
|
|
There was a problem hiding this comment.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
Suggested change
apganapa-adobe
approved these changes
Dec 18, 2025
Collaborator
|
Validation done on the PR on the below url in desktop , tablet and mobile . Few of accessibility testing , analytics testing and loc testing and bug fix is still in progress which will be taken up in next pr . Complete testing details are in Jira |
nkthakur48
approved these changes
Dec 18, 2025
Comment on lines
131
to
132
| const headers = { | ||
| 'x-product': CONFIG.API.PRODUCT, |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Suggested change
| const headers = { | |
| 'x-product': CONFIG.API.PRODUCT, | |
| const headers = {'x-product': CONFIG.API.PRODUCT, |
Comment on lines
132
to
133
| 'x-product': CONFIG.API.PRODUCT, | ||
| }; |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
Suggested change
| 'x-product': CONFIG.API.PRODUCT, | |
| }; | |
| 'x-product': CONFIG.API.PRODUCT,}; |
Collaborator
|
@suhjainadobe @hkhatana26 @hkuraware @drashti1712, please see if some of this feedback makes sense. We could take them as a fast follow-up since this PR is required on stage as soon as possible. |
nkthakur48
added a commit
that referenced
this pull request
Jan 6, 2026
* new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * Authorable row count per viewport * Personalised Edit template button for ios * new yt block * new yt block * new yt block * Free tag * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * Free tag authorable and is free check * free null check * Updated icons and added close icon for mobile * new yt block * new yt block * new yt block * new yt block * Fixed close card button click event * Added accessibilty for yt cards * Refactored code and resolved merge conflict * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * accessibilty changes for desktop * fixed video restart on tab * changes for tablet veiw is fixed * Fixed rtl issue for icons * new yt block * new yt block * new yt block * new yt block * new yt block * Fixed no-multiple-empty-lines eslint issue * changes for voice over on card * voiceover changes for overlay is fixed * Support both Akamai Proxy and Stock API based on query param * Fixed linting issue * MWPW-183578 PrM x YT gallery (#849) * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * Authorable row count per viewport * Personalised Edit template button for ios * new yt block * new yt block * new yt block * Free tag * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * Free tag authorable and is free check * free null check * Updated icons and added close icon for mobile * new yt block * new yt block * new yt block * new yt block * Fixed close card button click event * Added accessibilty for yt cards * Refactored code and resolved merge conflict * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * accessibilty changes for desktop * fixed video restart on tab * changes for tablet veiw is fixed * Fixed rtl issue for icons * new yt block * new yt block * new yt block * new yt block * new yt block * Fixed no-multiple-empty-lines eslint issue * changes for voice over on card * voiceover changes for overlay is fixed * Support both Akamai Proxy and Stock API based on query param * Fixed linting issue --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: himani-kuraware <hkuraware@adobe.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: hkhatana26 <hkhatana@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * new yt block * new yt block * new yt block * new yt block * new yt block * new yt block * MWPW-185518: Fixed tab functionality in firefox * bug fixes for tab and video functionality * free tag z-index * general formatting * general formatting * general formatting * MWPW-185625: Fixed shift tab in info button * stock api config * stock api config * stock api config * stock api config * Fixed shift tab in desktop and reverted voiceover changes --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: himani-kuraware <hkuraware@adobe.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: hkhatana26 <hkhatana@adobe.com> Co-authored-by: Suhani Jain <110388864+suhjainadobe@users.noreply.github.com>
nkthakur48
added a commit
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-183578
Test URLs:
Figma: https://www.figma.com/design/pkZPvgLkvA8lvPPqK5wCI6/PrM-YT-Partnership?node-id=1755-94482&t=lnlad6Y7TG9oSg6z-1