Skip to content

[MWPW-182813] [Firefly] second CTA support for Samsung S8 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robert-bogos wants to merge 3 commits into
base: stage
Choose a base branch
from
Open

[MWPW-182813] [Firefly] second CTA support for Samsung S8 #835

robert-bogos wants to merge 3 commits into from

Conversation

@robert-bogos
Copy link
Collaborator

@robert-bogos robert-bogos commented Nov 27, 2025

Description:
This PR adds second CTA support for Samsung Galaxy S8

Resolves: MWPW-182813

Test URLs:
Before: https://stage--cc--adobecom.aem.live/products/firefly
After: https://second-cta-support--cc--adobecom.aem.live/products/firefly

@robert-bogos robert-bogos self-assigned this Nov 27, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Nov 27, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 27, 2025 •
edited
Loading

Page Scores Audits Google
📱 /products/firefly PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/firefly PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@robert-bogos robert-bogos mentioned this pull request Nov 27, 2025
Closed
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 27, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@aem-code-sync aem-code-sync bot temporarily deployed to second-cta-support November 27, 2025 14:00 Inactive
@spadmasa spadmasa self-assigned this Nov 27, 2025
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 1, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@spadmasa
Copy link
Collaborator

spadmasa commented Dec 1, 2025

Validation done on the pr , In the us the page fix is seen as below
https://second-cta-support--cc--adobecom.aem.live/products/firefly
image

but in locale page do not see the fix working as expected @robert-bogos can you please take a look
https://second-cta-support--cc--adobecom.aem.page/il_he/products/firefly/landpa
image
https://second-cta-support--cc--adobecom.aem.page/de/products/firefly/landpa
image

cc: @nkthakur48

@nkthakur48
Copy link
Collaborator

nkthakur48 commented Dec 1, 2025

Will wait for @robert-bogos for RTL fix

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 2, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@nkthakur48
Copy link
Collaborator

nkthakur48 commented Dec 2, 2025

@spadmasa, As discussed with @narcis-radu, we will take the fix for RTL as a fast follow since not many devices will face this issue (RTL + Samsung S8 + Mobile). You could log a separate ticket for it.

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 3, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

5 similar comments
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 4, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 8, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 9, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 10, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 11, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 15, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

11 similar comments
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 16, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 17, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 18, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 22, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 23, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 24, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 25, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 29, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 30, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Dec 31, 2025

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Jan 1, 2026

Skipped merging 835: [MWPW-182813] [Firefly] second CTA support for Samsung S8 due to failing checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkthakur48 nkthakur48 nkthakur48 approved these changes

@hkuraware hkuraware hkuraware approved these changes

@spadmasa spadmasa Awaiting requested review from spadmasa

@drashti1712 drashti1712 Awaiting requested review from drashti1712

@suhjainadobe suhjainadobe Awaiting requested review from suhjainadobe

@hkhatana26 hkhatana26 Awaiting requested review from hkhatana26

Assignees

@spadmasa spadmasa

@robert-bogos robert-bogos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robert-bogos @spadmasa @nkthakur48 @hkuraware