-
Notifications
You must be signed in to change notification settings - Fork 58
[Firefly] Mobile LCP optimization followup #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks |
2 similar comments
|
Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks |
|
Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks |
1 similar comment
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
1 similar comment
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
@JingleH Looks like this may not be relevant as due to an additional banner at the top, that element is marked as LCP
Tests: |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks |
|
The code looks good, but it is very opinionated, everything revolves around the fact that the title would become LCP. However, as @nkthakur48 shared, adding a new element on the page might impact the overall functionality. |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
29 similar comments
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified |

Moves
flex:1to above 500px, this way on mobile, images will stay160pxbelow, making h1 the LCP rather than images. This can significantly reduce LCP as our image delivery still has some room for improvements.Long term suggestion for maintainability:
Long term perf suggestion:
loading=eagerandfetchpriority=highto itTest URLs:
Before: https://stage--cc--adobecom.aem.live/products/firefly?martech=off
After: https://ff-lcp-update--cc--adobecom.aem.live/products/firefly?martech=off
Before (SS1): lower score when LCP is the image

After (SS2): higher score when LCP is the h1 copy
