Skip to content

Conversation

@JingleH
Copy link
Collaborator

@JingleH JingleH commented Oct 24, 2025

Moves flex:1 to above 500px, this way on mobile, images will stay 160px below, making h1 the LCP rather than images. This can significantly reduce LCP as our image delivery still has some room for improvements.

Long term suggestion for maintainability:

  • gallery images should use fixed widths across breakpoints, rather than being too responsive with flex and screen width. Otherwise, the gallery's height would be very hard to control, potentially causing the first 2 sections to overlap or having large gap in between. With fixed widths and fixed heights (as images are squares here), we can control the gaps between 2 blocks via padding/bottom much more easily.
  • Authoring of the gallery's column positions can be retired. Hardcoding them should be easier for maintainance

Long term perf suggestion:

  • Author images directly in word docs to reduce network fetch to get image src and enable earlier browser discovery of resource
  • Duplicate the LCP image and place it first in the block and remove via js during decoration. This way Milo will automatically attach loading=eager and fetchpriority=high to it
  • Use webp
  • (optional) reduce network contention by lazy-loading non-LCP images, and especially mp4s, in the first block

Test URLs:

Before: https://stage--cc--adobecom.aem.live/products/firefly?martech=off
After: https://ff-lcp-update--cc--adobecom.aem.live/products/firefly?martech=off

Before (SS1): lower score when LCP is the image
Screenshot 2025-10-29 at 12 00 30

After (SS2): higher score when LCP is the h1 copy
Screenshot 2025-10-29 at 12 12 30

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 24, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 24, 2025

Page Scores Audits Google
📱 /products/firefly?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/firefly?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JingleH JingleH changed the title [Firefly] Mobile lcp optimization [Max2025][Firefly] Mobile lcp optimization Oct 24, 2025
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks

2 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Max2025][Firefly] Mobile lcp optimization due to failing checks

@JingleH JingleH changed the title [Max2025][Firefly] Mobile lcp optimization [Firefly] Mobile LCP optimization followup Oct 29, 2025
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

1 similar comment
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@nkthakur48
Copy link
Collaborator

nkthakur48 commented Nov 6, 2025

@JingleH Looks like this may not be relevant as due to an additional banner at the top, that element is marked as LCP

image

Tests:

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks

@narcis-radu
Copy link
Contributor

The code looks good, but it is very opinionated, everything revolves around the fact that the title would become LCP. However, as @nkthakur48 shared, adding a new element on the page might impact the overall functionality.
@nkthakur48, I think we can compare results and if the code change does not bring scores down, maybe we should consider merging and use it after the banner is removed.

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

29 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 803: [Firefly] Mobile LCP optimization followup due to missing verified label. kindly make sure that the PR has been verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants