Skip to content

Revert "removed adobe.com from stageDomainsMap (#450)" #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aishwaryamathuria merged 1 commit into from
Nov 15, 2024
Merged

Revert "removed adobe.com from stageDomainsMap (#450)" #452

aishwaryamathuria merged 1 commit into from
Nov 15, 2024

Conversation

@mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Nov 14, 2024 •
edited
Loading

@mirafedas mirafedas requested a review from a team November 14, 2024 11:15
@aem-code-sync
Copy link

aem-code-sync bot commented Nov 14, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 14, 2024

Skipped merging 452: Revert "removed adobe.com from stageDomainsMap (#450)" due to failing checks

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 14, 2024 •
edited
Loading

Page Scores Audits Google
📱 /careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 14, 2024

Skipped merging 452: Revert "removed adobe.com from stageDomainsMap (#450)" due to missing verified label. kindly make sure that the PR has been verified

@suhjainadobe suhjainadobe self-requested a review November 15, 2024 08:37
@spadmasa
Copy link
Collaborator

spadmasa commented Nov 15, 2024

Verified the product pages in revert pr
https://revert-7b3ad286441c925b949982632a9c9b6972f524e0--cc--adobecom.hlx.page/products/photoshop
image
modal will be loaded above the sticky promo with cta clickable

@spadmasa spadmasa self-assigned this Nov 15, 2024
@aishwaryamathuria aishwaryamathuria merged commit 98fc820 into stage Nov 15, 2024
14 checks passed
@milo-pr-merge-cc milo-pr-merge-cc bot mentioned this pull request Dec 2, 2024
Merged
@spadmasa spadmasa added the ready for main PR is ready to be merged to main branch label Dec 3, 2024
@aishwaryamathuria aishwaryamathuria deleted the revert-7b3ad286441c925b949982632a9c9b6972f524e0 branch March 7, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

Assignees

@spadmasa spadmasa

Labels

ready for main PR is ready to be merged to main branch ready for stage verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mirafedas @spadmasa @aishwaryamathuria @suhjainadobe