This repository was archived by the owner on Dec 5, 2025. It is now read-only.
MWPW-181073: T3 events with error handling #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rollout a page without a loc project * Rollout to langstore/en * Rollout to locales from langstore/XYZ * Ability to de-select regions * Can link out to pages before rollout
Upgrade da-bacom to hlx5
Consume stage again
Attempting to move back to file-based configs.
Sync Main
…ilities. Confirmed that all npm scripts work as expected (#7)
[Release] Stage to Main
Sync da-bacom with bacom
Sync da-bacom with bacom
Sync Stage and Main
* MWPW-174983 Add Tag Browser to Library * da config md * add tests * remove console
Sync da-bacom with bacom
Sync da-bacom with bacom
* MWPW-175525 Add Locale Selector to Library * Update translate config path
* MWPW-177491 Use stage milo libs link on stage * cr
As part of support added in milo to autoset AdobeTV captions based on locale a configuration key needs to be set. Refer: adobecom/milo#4674 Resolves: MWPW-168315 Co-authored-by: Raghu A <raga@Raghus-MacBook-Pro-2.local>
* Adds logic for collecting marketo options, the component, and an html file that can be turned into a test at some point * CR changes * Removing setting props so it can be tested by Dennis * Removing setting props so it can be tested by Dennis
* Frame is set up * Moved tags.js functionality into a tag-utils.js file, exported functions and added as imports to tags.js and tag-selector. Basics working * Working order, sl inputs do not work with map out of the box, or at least how it is implimented here * Adding basic tests. More comprehensive tests can be written during e2e testing and once the component is placed within the page. Will need to refactor these tests. * CR updates * Additional CR changes, moving strings to consts * CR changes
* MWPW-175545 Create simple generator * MWPW-175546 Generate template * MWPW-175985 Upload Images
JasonHowellSlavin
requested review from
Brandon32 and
meganthecoder
as code owners
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #350 +/- ##
==========================================
- Coverage 95.87% 94.36% -1.52%
==========================================
Files 13 20 +7
Lines 1430 2412 +982
==========================================
+ Hits 1371 2276 +905
- Misses 59 136 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Qiyun Dai <pianoquin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-181073
Test URLs: