#2060 Add reusable datatypes and examples supporting Paid Media #2061
Conversation
ejsuncy
force-pushed
the
master-2060-support-paid-media-datatypes
branch
2 times, most recently
from
9217174 to
ba1a1e6
Compare
ejsuncy
force-pushed
the
master-2060-support-paid-media-datatypes
branch
from
ba1a1e6 to
0463359
Compare
anandphatak
left a comment
anandphatak
left a comment
There was a problem hiding this comment.
Could you pl. also add the JIRA ticket number in the PR title? Also I think you need to update the PR number in the description.
| }, | ||
| "xdm:numberValue": { | ||
| "title": "Number Value", | ||
| "$ref": "https://ns.adobe.com/xdm/data/measure", |
There was a problem hiding this comment.
Any reason to use the data type Measure here? Do you also need the "id" field specified in the Measure? If not, then you could use "type": "number" rather than $ref to Measure data type; that way you won't need to have a nested "value" field under "numberValue".
There was a problem hiding this comment.
we thought we might need follow ADC schema on Analytics side. You are right, it turns out we don't need "id" field for paidmedia schema. I changed it back to number type.
| "title": "Creative Assets", | ||
| "description": "Media assets used in the creative", | ||
| "items": { | ||
| "$ref": "#/definitions/asset" |
There was a problem hiding this comment.
Do you reuse the "asset" block defined in the schema in the future? Wanted to find out why it was taken out from the items and defined as a separate block.
There was a problem hiding this comment.
I don't think we might reuse "asset" in the schema, should I move it in items?
| "description": "Data type representing creative assets and content for paid media ads", | ||
| "definitions": { | ||
| "creative": { | ||
| "properties": { |
There was a problem hiding this comment.
I'd recommend to keep these fields inside an object that acts like a namespace, for example "xdm:paidMediaCreative". You can choose an appropriate name that does not clash; some of the fields defined in this datatype clash with other datatypes in global XDM (for example "xdm:createiveID", "xdm:body", "xdm:destinationURL".) By nesting inside an object will avoid collisions
There was a problem hiding this comment.
changed creative to paidMediaCreative to avoid collisions.
This reverts commit 0463359.
3 participants
#2060 will involve multiple PRs to keep the review effort manageable.
This PR adds the initial base datatypes that will be reused across multiple schemas in future PRs to support Paid Media concepts.