Update remote-storage.js #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pru55e11
added a commit
that referenced
this pull request
Aug 27, 2025
This fixes the proxy bypass issue that occurred after the migration from AWS SDK v2 to v3 in March 2023. PROBLEM: - AWS SDK v3 requires different proxy configuration than v2 - Adobe I/O CLI S3 uploads were bypassing corporate proxies - ECONNRESET errors in corporate environments SOLUTION: - Add NodeHttpHandler with ProxyAgent for AWS SDK v3 compatibility - Support multiple proxy environment variables (https_proxy, HTTPS_PROXY, ALL_PROXY, http_proxy) - Maintain CommonJS compatibility (fixes ES6 import issues from PR #224) - Priority: HTTPS_PROXY > ALL_PROXY > HTTP_PROXY DEPENDENCIES: - @smithy/node-http-handler: AWS SDK v3 HTTP handler - proxy-agent: Universal proxy support Inspired-by: PR #224 by pat-lego Fixes: proxy bypass for Adobe I/O CLI S3 operations
pru55e11
added a commit
that referenced
this pull request
Aug 27, 2025
This fixes the proxy bypass issue that occurred after the migration from AWS SDK v2 to v3 in March 2023. PROBLEM: - AWS SDK v3 requires different proxy configuration than v2 - Adobe I/O CLI S3 uploads were bypassing corporate proxies - ECONNRESET errors in corporate environments SOLUTION: - Add NodeHttpHandler with ProxyAgent for AWS SDK v3 compatibility - Support standard proxy environment variables (https_proxy, HTTPS_PROXY, http_proxy, HTTP_PROXY) - Maintain CommonJS compatibility (fixes ES6 import issues from PR #224) - Priority: HTTPS_PROXY > HTTP_PROXY (HTTPS takes precedence for S3) DEPENDENCIES: - @smithy/node-http-handler: AWS SDK v3 HTTP handler - proxy-agent: Universal proxy support Inspired-by: PR #224 by pat-lego Fixes: proxy bypass for Adobe I/O CLI S3 operations
pru55e11
added a commit
that referenced
this pull request
Aug 27, 2025
This fixes the proxy bypass issue that occurred after the migration from AWS SDK v2 to v3 in March 2023. PROBLEM: - AWS SDK v3 requires different proxy configuration than v2 - Adobe I/O CLI S3 uploads were bypassing corporate proxies - ECONNRESET errors in corporate environments SOLUTION: - Add NodeHttpHandler with ProxyAgent for AWS SDK v3 compatibility - Support standard proxy environment variables (https_proxy, HTTPS_PROXY, http_proxy, HTTP_PROXY) - Maintain CommonJS compatibility (fixes ES6 import issues from PR #224) - Priority: HTTPS_PROXY > HTTP_PROXY (HTTPS takes precedence for S3) - Only configure requestHandler when proxy is actually set DEPENDENCIES: - @smithy/node-http-handler: AWS SDK v3 HTTP handler - proxy-agent: Universal proxy support TESTS: - Comprehensive proxy configuration tests for all environment variables - Proxy priority testing (HTTPS takes precedence) - No-proxy scenario testing Inspired-by: PR #224 by pat-lego Fixes: proxy bypass for Adobe I/O CLI S3 operations
10 tasks
pru55e11
added a commit
that referenced
this pull request
Aug 27, 2025
This fixes the proxy bypass issue that occurred after the migration from AWS SDK v2 to v3 in March 2023. PROBLEM: - AWS SDK v3 requires different proxy configuration than v2 - Adobe I/O CLI S3 uploads were bypassing corporate proxies - ECONNRESET errors in corporate environments SOLUTION: - Add NodeHttpHandler with ProxyAgent for AWS SDK v3 compatibility - Support standard proxy environment variables (https_proxy, HTTPS_PROXY, http_proxy, HTTP_PROXY) - Maintain CommonJS compatibility (fixes ES6 import issues from PR #224) - Priority: HTTPS_PROXY > HTTP_PROXY (HTTPS takes precedence for S3) - Only configure requestHandler when proxy is actually set DEPENDENCIES: - @smithy/node-http-handler: AWS SDK v3 HTTP handler - proxy-agent: Universal proxy support TESTS: - Comprehensive proxy configuration tests for all environment variables - Proxy priority testing (HTTPS takes precedence) - No-proxy scenario testing - All ESLint rules followed Inspired-by: PR #224 by pat-lego Fixes: proxy bypass for Adobe I/O CLI S3 operations
Contributor
|
Released via PR #225 - thanks so much for the submission! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 bucket should allow for Proxy support