Test app iOS and Android version update and Android IAM display fixes#151
Conversation
… for Android IAM not displaying
...d/src/main/java/com/adobe/marketing/mobile/flutter/flutter_aepcore/FlutterAEPCorePlugin.java
Show resolved
Hide resolved
|
|
||
| kotlinOptions { | ||
| jvmTarget = '1.8' | ||
| languageVersion = "1.4" |
There was a problem hiding this comment.
Can you keep this and update it to 1.5 so that it matches what we use in native SDKs?
There was a problem hiding this comment.
Flutter gives a warning if the Kotlin compiler version is below 2.1.0 which only supports language version of 1.6. That's the minimum version I can set
There was a problem hiding this comment.
There was a problem hiding this comment.
What happen if the user uses higher Kotlin version than 1.5?
There was a problem hiding this comment.
The flutter bridge library can use features introduced in Kotlin 1.5 (or whatever version is specified). The actual compiler version used for the build is derived from the highest among all modules, the test app in this case, which is 2.1.0 and requires minimum language version of 1.6. The native SDKs are already compiled so it won't throw any errors. The flutter bridge code is not and thus the warnings.
|
|
||
| kotlinOptions { | ||
| jvmTarget = '1.8' | ||
| languageVersion = "1.6" |
There was a problem hiding this comment.
Why is it 1.6? We are using 1.5 for our android SDKs.
There was a problem hiding this comment.
This is for the flutter Android bridge code, not the native SDK. Since latest version of flutter throws a warning when Kotlin Compiler version below 2.1.0 is used, I updated the languageVersion to the corresponding minimum supported version which is 1.6
There was a problem hiding this comment.
I did not see your earlier comment.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: